Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AvatarStack): Add support for className prop #5097

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

randall-krauskopf
Copy link
Contributor

@randall-krauskopf randall-krauskopf commented Oct 9, 2024

Related To: https://github.com/github/collaboration-workflows-flex/issues/1297

Changelog

New

Added className prop to the AvatarStack component for CSS Module support.

Changed

Removed

Rollout strategy

  • Minor release

Copy link

changeset-bot bot commented Oct 9, 2024

🦋 Changeset detected

Latest commit: c9dd0e0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 9, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 9, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5097 October 9, 2024 19:48 Inactive
Copy link
Contributor

github-actions bot commented Oct 9, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.9 KB (+0.01% 🔺)
packages/react/dist/browser.umd.js 97.19 KB (-0.05% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-5097 October 9, 2024 20:24 Inactive
@randall-krauskopf randall-krauskopf changed the title add support for className prop in the avatar stack Add support for className prop in the avatar stack Oct 9, 2024
@randall-krauskopf randall-krauskopf changed the title Add support for className prop in the avatar stack feat(AvatarStack): Add support for className prop Oct 9, 2024
@randall-krauskopf randall-krauskopf marked this pull request as ready for review October 9, 2024 20:55
@randall-krauskopf randall-krauskopf requested a review from a team as a code owner October 9, 2024 20:55
Copy link
Collaborator

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok to me 👍

@randall-krauskopf randall-krauskopf added this pull request to the merge queue Oct 10, 2024
@randall-krauskopf randall-krauskopf removed this pull request from the merge queue due to a manual request Oct 10, 2024
@randall-krauskopf randall-krauskopf added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit 2a3c473 Oct 10, 2024
45 checks passed
@randall-krauskopf randall-krauskopf deleted the avatar-stack-classname branch October 10, 2024 13:59
@primer primer bot mentioned this pull request Oct 10, 2024
@primer primer bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants