Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ButtonBase to experimental #5099

Merged
merged 6 commits into from
Oct 10, 2024

Conversation

joshblack
Copy link
Member

To help with wildcard import migrations, I'm adding ButtonBase to @primer/react/experimental since this is currently being used downstream. This seemed like an appropriate place for now since we don't necessarily want to expose this as a stable component.

Changelog

New

  • Add ButtonBase to @primer/react/experimental

Changed

Removed

Rollout strategy

  • Minor release

@joshblack joshblack requested a review from a team as a code owner October 9, 2024 20:21
Copy link

changeset-bot bot commented Oct 9, 2024

🦋 Changeset detected

Latest commit: 0747989

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

github-actions bot commented Oct 9, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.91 KB (+0.02% 🔺)
packages/react/dist/browser.umd.js 97.27 KB (+0.05% 🔺)

Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seemed like an appropriate place for now since we don't necessarily want to expose this as a stable component.

Makes sense!

@joshblack joshblack added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit cb21a38 Oct 10, 2024
44 checks passed
@joshblack joshblack deleted the featt/add-button-base-to-experimental branch October 10, 2024 15:06
@primer primer bot mentioned this pull request Oct 10, 2024
@primer primer bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants