Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Details): Convert Details to css module behind feature flag #5167

Merged
merged 6 commits into from
Oct 24, 2024
Merged

feat(Details): Convert Details to css module behind feature flag #5167

merged 6 commits into from
Oct 24, 2024

Conversation

jonrohan
Copy link
Member

Closes https://github.com/github/primer/issues/4136

Changelog

Changed

Convert Details to css module behind feature flag

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@jonrohan jonrohan requested a review from a team as a code owner October 21, 2024 21:29
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 1b1eeb8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Oct 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 21, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5167 October 21, 2024 21:32 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.12 KB (+0.09% 🔺)
packages/react/dist/browser.umd.js 97.5 KB (+0.12% 🔺)

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/348108

@primer primer bot requested a review from a team as a code owner October 21, 2024 21:37
@primer primer bot requested a review from langermank October 21, 2024 21:37
@github-actions github-actions bot temporarily deployed to storybook-preview-5167 October 21, 2024 21:40 Inactive
@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot temporarily deployed to storybook-preview-5167 October 22, 2024 16:43 Inactive
broccolinisoup
broccolinisoup approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left one question but not a blocker.

e2e/components/Details.test.ts
colorScheme: theme,
},
})
const stories: Array<{title: string; id: string}> = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that a new practise we're exploring that includes the stories in the e2e test file? 👀

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah @joshblack started doing this in some of the other tests and thought I would unify around it

@jonrohan jonrohan added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit 07b75e7 Oct 24, 2024
43 checks passed
@jonrohan jonrohan deleted the css_modules_details branch October 24, 2024 01:02
@primer primer bot mentioned this pull request Oct 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broccolinisoup broccolinisoup broccolinisoup approved these changes

@langermank langermank Awaiting requested review from langermank langermank is a code owner automatically assigned from primer/design-reviewers

Assignees
No one assigned
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonrohan @broccolinisoup