Remove extra span nesting

primer · Apr 26, 2024 · 4b5b1e0 · 4b5b1e0
1 parent 554de3f
commit 4b5b1e0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/components/primer/beta/button.html.erb b/app/components/primer/beta/button.html.erb
@@ -10,7 +10,7 @@
       <span class="Button-visual Button-trailingVisual">
         <% if @trailing_visual_counter %>
           <span class="sr-only">(<%= trailing_visual %>)</span>
-          <span aria-hidden="true"><%= trailing_visual %></span>
+          <%= trailing_visual %>
         <% else %>
           <%= trailing_visual %>
         <% end %>

diff --git a/app/components/primer/beta/button.rb b/app/components/primer/beta/button.rb
@@ -70,7 +70,7 @@ class Button < Primer::Component
         label: Primer::Beta::Label,
         counter: lambda { |**system_arguments|
           @trailing_visual_counter = true
-          Primer::Beta::Counter.new(**system_arguments)
+          Primer::Beta::Counter.new("aria-hidden": true, **system_arguments)
         }
       }