Update details_menu_migration linter config (#3139)

primer · Oct 21, 2024 · b650344 · b650344
1 parent 683abd2
commit b650344
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/.changeset/new-nails-walk.md b/.changeset/new-nails-walk.md
@@ -0,0 +1,5 @@
+---
+'@primer/view-components': patch
+---
+
+Adjusts config for DetailsMenuMigration linter to take in an array of strings instead of array of regexp
diff --git a/lib/primer/view_components/linters/details_menu_migration.rb b/lib/primer/view_components/linters/details_menu_migration.rb
@@ -16,7 +16,7 @@ class DetailsMenuMigration < Linter
 
           # Allow custom pattern matching for ERB nodes
           class ConfigSchema < LinterConfig
-            property :custom_erb_pattern, accepts: array_of?(Regexp),
+            property :custom_erb_pattern, accepts: array_of?(String),
               default: -> { [] }
           end
           self.config_schema = ConfigSchema
@@ -51,7 +51,8 @@ def custom_erb_pattern
                 if @config.custom_erb_pattern.empty?
                   nil
                 else
-                  Regexp.new(@config.custom_erb_pattern.join("|"), true)
+                  regexes = @config.custom_erb_pattern.map { |pattern| Regexp.new(pattern, true) }
+                  Regexp.new(regexes.join("|"), true)
                 end
             end
 

diff --git a/test/lib/erblint/details_menu_migration_test.rb b/test/lib/erblint/details_menu_migration_test.rb
@@ -54,7 +54,8 @@ def test_does_not_warn_if_inline_disable_comment
   end
 
   def test_accepts_custom_regex_pattern
-    @linter.config.custom_erb_pattern = [/render[\s\(]GitHub::MenuComponent/]
+    @linter.config.custom_erb_pattern = ["render[\s\(]GitHub::MenuComponent"]
+
     @file = <<~HTML
       <%= render GitHub::MenuComponent.new do %>
     HTML
@@ -64,7 +65,8 @@ def test_accepts_custom_regex_pattern
   end
 
   def test_accepts_multiple_custom_regex_pattern
-    @linter.config.custom_erb_pattern = [/render[\s\(]GitHub::MenuComponent/, /SomeOtherComponent/]
+    @linter.config.custom_erb_pattern = ["render[\s\(]GitHub::MenuComponent", "SomeOtherComponent"]
+
     @file = <<~HTML
       <%= render GitHub::MenuComponent.new do %>
       <% end %>