Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using custom properties fallback plugin to fallback primitives #1990

Merged
merged 6 commits into from
May 10, 2023

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented May 4, 2023

Description

Describe your changes here.

🤖 Generated by Copilot at 800210d

This pull request updates the dependencies, configuration, and CSS code to support the migration to color tokens and fallbacks from @primer/primitives. It also improves the order of some classes in static/classes.json for consistency.

Integration

Does this change require any updates to code in production?

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

Co-authored-by: Katie Langerman <langermank@users.noreply.github.com>
@changeset-bot
Copy link

changeset-bot bot commented May 4, 2023

🦋 Changeset detected

Latest commit: 2538e61

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan temporarily deployed to preview May 4, 2023 21:40 — with GitHub Actions Inactive
@github-actions github-actions bot added the css Pull requests that update CSS code label May 4, 2023
@jonrohan jonrohan temporarily deployed to github-pages May 4, 2023 21:46 — with GitHub Actions Inactive
@langermank langermank temporarily deployed to preview May 10, 2023 17:55 — with GitHub Actions Inactive
@langermank langermank temporarily deployed to github-pages May 10, 2023 18:02 — with GitHub Actions Inactive
@langermank langermank marked this pull request as ready for review May 10, 2023 22:16
@langermank langermank requested a review from a team as a code owner May 10, 2023 22:16
@langermank langermank requested review from a team, lukasoppermann and keithamus May 10, 2023 22:16
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@github-actions github-actions bot removed the css Pull requests that update CSS code label May 10, 2023
@langermank langermank merged commit 15553fa into main May 10, 2023
@langermank langermank deleted the custom_properties_fallbacks branch May 10, 2023 23:04
@primer-css primer-css mentioned this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants