Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix popover open selector for anchored position #2006

Merged
merged 4 commits into from
May 16, 2023

Conversation

keithamus
Copy link
Member

Description

Missed another popover-open selector.

This one fixes the menu staying open even when focussed out from.

Integration

Does this change require any updates to code in production?

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@keithamus keithamus requested review from a team and camertron May 11, 2023 15:59
@changeset-bot
Copy link

changeset-bot bot commented May 11, 2023

🦋 Changeset detected

Latest commit: 5507a0b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@keithamus keithamus temporarily deployed to preview May 11, 2023 15:59 — with GitHub Actions Inactive
@github-actions github-actions bot added patch release javascript Pull requests that update Javascript code labels May 11, 2023
@keithamus keithamus temporarily deployed to github-pages May 11, 2023 16:03 — with GitHub Actions Inactive
@keithamus keithamus force-pushed the fix-popover-open-selector-for-anchored-position branch from 89640eb to 5507a0b Compare May 16, 2023 12:02
@jonrohan jonrohan merged commit 7282911 into main May 16, 2023
@jonrohan jonrohan deleted the fix-popover-open-selector-for-anchored-position branch May 16, 2023 12:05
@primer-css primer-css mentioned this pull request May 16, 2023
camertron pushed a commit that referenced this pull request May 19, 2023
Co-authored-by: Jon Rohan <rohan@github.com>
jonrohan added a commit that referenced this pull request May 25, 2023
Co-authored-by: Jon Rohan <rohan@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants