Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label BorderBox lists with their header #2202

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Conversation

camertron
Copy link
Contributor

@camertron camertron commented Aug 10, 2023

What are you trying to accomplish?

BorderBox lists, i.e. <ul>s, should have an aria-labelledby pointing at the header, if it exists.

Integration

No changes required in production,

List the issues that this change affects.

Closes https://github.com/github/primer/issues/2546

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

@changeset-bot
Copy link

changeset-bot bot commented Aug 10, 2023

🦋 Changeset detected

Latest commit: 1cedf11

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix

@camertron
Copy link
Contributor Author

All credit to @andrialexandrou for identifying this one 😄

@camertron camertron marked this pull request as ready for review August 10, 2023 23:27
@camertron camertron requested a review from a team August 10, 2023 23:27
@camertron camertron merged commit d7da401 into main Aug 11, 2023
28 checks passed
@camertron camertron deleted the border_box_label_with_header branch August 11, 2023 02:56
@primer primer bot mentioned this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch release ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants