Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused docs/static npm scripts since docsite is static #2221

Merged
merged 8 commits into from
Aug 22, 2023

Conversation

jonrohan
Copy link
Member

What are you trying to accomplish?

I ran script/dev and noticed it was compiling the JS and CSS assets for docs/static folder. Correct me if I'm wrong but I don't believe we need these anymore since #2193 shipped?

Integration

No

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@jonrohan jonrohan requested review from a team and camertron August 22, 2023 20:30
@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2023

⚠️ No Changeset found

Latest commit: c4b922b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jonrohan jonrohan added the skip changeset Pull requests that don't change the library output label Aug 22, 2023
jonrohan and others added 6 commits August 22, 2023 20:49
Co-authored-by: mjimenez98 <mjimenez98@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@jonrohan jonrohan requested a review from a team as a code owner August 22, 2023 20:50
@github-actions github-actions bot added minor release javascript Pull requests that update Javascript code ruby Pull requests that update Ruby code css Pull requests that update CSS code and removed minor release labels Aug 22, 2023
@github-actions github-actions bot removed javascript Pull requests that update Javascript code ruby Pull requests that update Ruby code css Pull requests that update CSS code labels Aug 22, 2023
@jonrohan jonrohan enabled auto-merge (squash) August 22, 2023 20:53
@jonrohan jonrohan merged commit f55865f into main Aug 22, 2023
27 checks passed
@jonrohan jonrohan deleted the remove_remaining_docs_scripts branch August 22, 2023 22:51
@jonrohan jonrohan temporarily deployed to preview August 22, 2023 22:51 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Pull requests that don't change the library output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants