Fix issue preventing expansion and collapse of nav list items with tooltips #2765
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
NavList
items with tooltips currently cannot be expanded or collapsed.Screenshots
Here's a video showing that
NavList
sub items can be expanded and collapsed even when they have thetruncate_text: :show_tooltip
option set.tooltip_nav_item.mov
Integration
No changes necessary in production.
Risk Assessment
What approach did you choose and why?
Our JS code identifies the sub list via
nextElementSibling
, which may instead be the tooltip element. The solution is to move the tooltip element to a different part of the rendered output.Accessibility
Merge checklist