Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrapping behavior of toggle switch label #2952

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

camertron
Copy link
Contributor

@camertron camertron commented Jul 17, 2024

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

This PR fixes the wrapping behavior of toggle switch captions for consistency with our documentation on the subject.

Screenshots

Before After
A screenshot of an example toggle switch form showing the caption wrapped onto multiple lines. It appears to the right of the toggle switch itself. A screenshot of an example toggle switch form showing a caption that has not wrapped. It appears underneath the toggle switch.

Integration

No changes necessary in production - this change is purely visual.

List the issues that this change affects.

Fixes #2943

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

- [ ] Added/updated tests
- [ ] Added/updated documentation
- [ ] Added/updated previews (Lookbook)

  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Copy link

changeset-bot bot commented Jul 17, 2024

🦋 Changeset detected

Latest commit: 89d9d93

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@camertron camertron marked this pull request as ready for review July 17, 2024 22:36
@camertron camertron requested a review from a team as a code owner July 17, 2024 22:36
@camertron camertron requested review from langermank and jonrohan and removed request for langermank July 17, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caption of ToggleSwitchForm is given too little space
2 participants