All requests from ToggleSwitch
are being made with a Turbo Accept header
#3012
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Fix a bug where all requests from the
ToggleSwitch
view component are being made with a TurboAccept
header. This started happening after the change in #2964 becausedata-turbo=false
gets interpreted as a truthy value.It also kind of says that in https://catalyst.rocks/guide/attrs/#boolean-attributes but it's not totally clear IMO.
Integration
No
Risk Assessment
What approach did you choose and why?
Conditionally set
data-turbo
, instead of always.Anything you want to highlight for special attention from reviewers?
Accessibility
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.