Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All requests from ToggleSwitch are being made with a Turbo Accept header #3012

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

orhantoy
Copy link
Contributor

What are you trying to accomplish?

Fix a bug where all requests from the ToggleSwitch view component are being made with a Turbo Accept header. This started happening after the change in #2964 because data-turbo=false gets interpreted as a truthy value.
It also kind of says that in https://catalyst.rocks/guide/attrs/#boolean-attributes but it's not totally clear IMO.

Integration

No

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Conditionally set data-turbo, instead of always.

Anything you want to highlight for special attention from reviewers?

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

That's because `data-turbo=false` gets interpreted as a truthy value.
Copy link

changeset-bot bot commented Aug 16, 2024

🦋 Changeset detected

Latest commit: aa76456

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@orhantoy orhantoy marked this pull request as ready for review August 16, 2024 12:35
@orhantoy orhantoy requested a review from a team as a code owner August 16, 2024 12:35
@orhantoy orhantoy changed the title ToggleSwitch: data-turbo attr should only be set when enabled All requests from ToggleSwitch are being made with a Turbo Accept header Aug 16, 2024
@keithamus keithamus merged commit adcdddd into main Aug 16, 2024
38 checks passed
@keithamus keithamus deleted the orhantoy/fix-ToggleSwitch-data-turbo branch August 16, 2024 13:00
@primer primer bot mentioned this pull request Aug 16, 2024
@camertron
Copy link
Contributor

Thanks for this 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants