Don't select the item if it's an href

[owenniblock]

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

Don't display a checkmark when anchor items are activated

We could alternatively use the tag and check for :a but I figured this approach would work and was less prone to causing problems if folks are using tags in a weird way but still want stuff to be selectable.

Integration

No

List the issues that this change affects.

Closes https://github.com/github/primer/issues/3886

Risk Assessment

• Low risk the change is small, highly observable, and easily rolled back.
• Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
• High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Because this only affects SelectPanel directly, we should know if we have any SelectPanels with links for items which don't actually redirect to a new page.

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

Accessibility

• No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Lookbook)
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

[changeset-bot]

🦋 Changeset detected

Latest commit: 38ee542

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/view-components	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[owenniblock]

Questions:

• Do we want to do the same for multi-select?
• Should we add a selected item to the example so it's obvious that this is supported?

[camertron]

Awesome, thanks!

[camertron]

Do we want to do the same for multi-select?

Hmm, I don't think so? I can see a scenario where you might want to show two selections, but nobody's asking for that right now, so let's not worry about it.

Should we add a selected item to the example so it's obvious that this is supported?

Like to the "list of links" example? Yes, that would be nice to have 👍

[github-actions]

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences