Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug when remove images #202

Merged
merged 1 commit into from
Oct 7, 2024
Merged

fix bug when remove images #202

merged 1 commit into from
Oct 7, 2024

Conversation

yitianlian
Copy link
Contributor

Reference Issues/PRs

None

What does this implement/fix? Explain your changes.

There is no image_id attribute for dep, which type is string and it's the image id. So removing this will eliminate the bug

Any other comments?

🧡 Thanks for contributing!

@john-b-yang
Copy link
Collaborator

Thanks so much for the catch @yitianlian and @klieret for the approval! Just merged.

@john-b-yang john-b-yang merged commit 0f99aef into princeton-nlp:main Oct 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klieret klieret klieret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yitianlian @john-b-yang @klieret