Pin tox packages for sphinx images #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I reproduced this and your changes work! |
|
Thanks Albert! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I rebuilt the sphinx images to test all SWE-Bench Verified instances all newly built images started to fail. Seems to be because of a new version of
tox. This PR is to pin the version in the previously built images. Which seems to work.Compare this benchmark run with failing sphinx instances:
https://eval.moatless.ai/evaluations/fcbb473f957149e7a5a45baeaa11800c
With this fix it looks like this:
https://eval.moatless.ai/evaluations/ab7a61b78e334a759fff3b344d30bd70