Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix docker building issues with sklearn #226

Merged
merged 1 commit into from
Oct 7, 2024
Merged

fix docker building issues with sklearn #226

merged 1 commit into from
Oct 7, 2024

Conversation

wistuba
Copy link
Contributor

@wistuba wistuba commented Oct 1, 2024

Reference Issues/PRs

Fixes #218

What does this implement/fix? Explain your changes.

Fixes docker building issues for

  • scikit-learn__scikit-learn-25973
  • scikit-learn__scikit-learn-25747
  • scikit-learn__scikit-learn-25102
  • scikit-learn__scikit-learn-25931
  • scikit-learn__scikit-learn-25232
  • scikit-learn__scikit-learn-26194
  • scikit-learn__scikit-learn-26323

Not all constraints might be necessary, but it should avoid more things to break in the future.

klieret
klieret approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@klieret klieret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I tested this with scikit-learn__scikit-learn-25500 and it seems to work :)

@john-b-yang
Copy link
Collaborator

Thanks so much for the fix @wistuba! Tysm @klieret as well for the approval! Merged.

@john-b-yang john-b-yang merged commit ba221bb into princeton-nlp:main Oct 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klieret klieret klieret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scikit-learn__scikit-learn images built error
3 participants
@wistuba @john-b-yang @klieret