Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Issues with yanked pkg types-setuptools #232

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

klieret
Copy link
Member

@klieret klieret commented Oct 7, 2024

Closes #199

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 23.07692% with 10 lines in your changes missing coverage. Please review.

Project coverage is 54.37%. Comparing base (cc7c3bc) to head (a4a4e86).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
swebench/harness/test_spec.py 23.07% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
- Coverage   54.57%   54.37%   -0.21%     
==========================================
  Files          20       20              
  Lines        1979     1990      +11     
==========================================
+ Hits         1080     1082       +2     
- Misses        899      908       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@john-b-yang
Copy link
Collaborator

Tysm @klieret for the fix! Makes sense - good way to catch any easy replacements that need to be there. Merged!

@john-b-yang john-b-yang merged commit 072bbe3 into main Oct 7, 2024
3 checks passed
@john-b-yang john-b-yang deleted the fixed-yanked-types-pkg-resources branch October 7, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yanked package types-pkg-resources causes failures when evaluating on sqlfluff
2 participants