Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misplaced quotes in get_top_pypi.py #235

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Fix misplaced quotes in get_top_pypi.py #235

merged 1 commit into from
Oct 17, 2024

Conversation

dash-xa
Copy link
Contributor

@dash-xa dash-xa commented Oct 17, 2024 •
edited
Loading

Fix insidious bug

@dash-xa dash-xa changed the title Fix misplaced quotes bug in get_top_pypi.py Fix misplaced quotes in get_top_pypi.py Oct 17, 2024
klieret
klieret approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@klieret klieret left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hahaha nice catch! mea culpa

@john-b-yang
Copy link
Collaborator

Wow nice catch! Thanks for the fix :)

@john-b-yang john-b-yang merged commit c7d4d9d into princeton-nlp:main Oct 17, 2024
1 check passed
@dash-xa
Copy link
Contributor Author

dash-xa commented Oct 23, 2024

Happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klieret klieret klieret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dash-xa @john-b-yang @klieret