-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
11865a6
to
606fe1d
Compare
32033d2
to
97aa601
Compare
97aa601
to
d184cb4
Compare
d184cb4
to
5505044
Compare
07af646
to
e76fb8e
Compare
Started onboarding myself into this pr tonight. A small dep change to fix a yarn warning allowed the tests to pass locally. |
I didn't observe carefully before. Looking again at the tests running on c, I noticed that the two "large-schema" tests are missing from the output, e.g. from local:
When I isolate the Looking at past recent failures it seems there is a random-like failure among "basic" and "large" schema tests across both TS and FT. I would ssh into the build container but I don't have permission: |
32cbd52
to
eedf697
Compare
|
b5b587f
to
353b212
Compare
Eventually figured out that the disk contention was not the root cause (probably not implicated at all). There are quite a few existing issues on the inerwebs about cci/travis not handling jest auto-cpu-count detection well. Capping worker count on CI worked here too. I found one flow test that was commented out and needed finishing, export interface Mutation_AddMemberData {
email: string;
projects: string[];
}
export interface Mutation_Args_AddMember {
data: AddMemberData;
} I now append prefixes to the types of field arguments (in the above case... |
@@ -2,7 +2,11 @@ import * as os from 'os' | |||
import * as prettier from 'prettier' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This module contains bug-fix code in response to the new compilation step we do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot both @Weakky and @jasonkuhrt for all this work! This will add soo much stability to our releases. Besides the two let
s, the PR looks amazing 🙌
@timsuchanek let me know if there are any other blocking issues in this PR from your point of view. |
@timsuchanek given that you seemed pretty satisfied already and I've fixed the two style issues you noted, going to merge, keep things rolling. And these tests like you said will start helping immediately : ) |
Tries to compile every tests to make sure there are no errors
Fixes #69