Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

perf: introduce benchmarks #372

Merged
merged 25 commits into from
Dec 31, 2018
Merged

perf: introduce benchmarks #372

merged 25 commits into from
Dec 31, 2018

Conversation

jasonkuhrt
Copy link
Member

@jasonkuhrt jasonkuhrt commented Dec 27, 2018

This contributes long-term toward tracking and improving issues like what #310 appeared to be at first (it later turned out to be a bug manifesting somewhat like bad perf, in that case).

TODO

  • consider removing path relative util functions as their help may not outweigh their surprise
  • optionally save benchmark results to JSON data that can be easily charted somewhere
  • setup ci to run and commit benchmarks for every master commit
  • add architecture docs about how to work on the benchmark system
  • add reference docs about how to add new benchmarks
  • flow benchmarks
  • final sanity check on diff, refactor/clean as needed

@jasonkuhrt jasonkuhrt self-assigned this Dec 27, 2018
@jasonkuhrt
Copy link
Member Author

One of these or other tools might be useful to visualize benchmark results over time:

We could create a sandbox at https://codesandbox.io/ to host the charts. Maybe pull down the JSON from github raw link.

@jasonkuhrt
Copy link
Member Author

jasonkuhrt commented Dec 28, 2018

Not going to do the the ci automation part yet, because:

  • its a monorepo, not all changes will be related to graphqlgen

  • enforcing that every second commit become a benchmark history update might be really annoying for the git history... maybe it should only be done for e.g. perf-type and feature-type commits

  • maybe we should use CI to generate a PR comment containing benchmark runs, that comment being updated upon every PR commit...

I think these things need more discussion. For now we can start with the manual process.

--edit

issue made #375

@jasonkuhrt jasonkuhrt merged commit 4584b57 into master Dec 31, 2018
@jasonkuhrt jasonkuhrt deleted the perf/spike-benchmarks branch December 31, 2018 04:21
@jasonkuhrt jasonkuhrt mentioned this pull request Jan 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant