Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set MSRV as 1.46 #14

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Set MSRV as 1.46 #14

merged 1 commit into from
Feb 19, 2021

Conversation

iBluemind
Copy link
Contributor

@iBluemind iBluemind commented Feb 19, 2021

To resolve the compile error like below.

From<char> for String implementation was included from Rust 1.46.
rust-lang/rust#73466

Then, set MSRV in Cargo.toml by rust-lang/rfcs#2495

error[E0277]: the trait bound `std::string::String: std::convert::From<char>` is not satisfied
   --> src/jdbc.rs:244:22
    |
244 |     let mut output = String::from('[');
    |                      ^^^^^^^^^^^^ the trait `std::convert::From<char>` is not implemented for `std::string::String`
    |
    = help: the following implementations were found:
              <std::string::String as std::convert::From<&mut str>>
              <std::string::String as std::convert::From<&std::string::String>>
              <std::string::String as std::convert::From<&str>>
              <std::string::String as std::convert::From<std::borrow::Cow<'a, str>>>
              <std::string::String as std::convert::From<std::boxed::Box<str>>>
    = note: required by `std::convert::From::from`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0277`.
error: could not compile `connection-string`.

Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great; thanks heaps!

@yoshuawuyts yoshuawuyts merged commit e0decb5 into prisma:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants