Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: link inside a repeatable contain a key #363

Merged
merged 3 commits into from
Dec 11, 2024
Merged

fix: link inside a repeatable contain a key #363

merged 3 commits into from
Dec 11, 2024

Conversation

xrutayisire
Copy link
Contributor

Resolves: DT-2452: Better repeatable link code snippets

Description

  • Ensure that when wrapping a LinkField in a repeatable it will contain a key

Checklist

  • A comprehensive Linear ticket, providing sufficient context and details to facilitate the review of the PR, is linked to the PR.
  • If my changes require tests, I added them.
  • If my changes affect backward compatibility, it has been discussed.
  • If my changes require an update to the CONTRIBUTING.md guide, I updated it.

Preview

How to QA 1

Footnotes

  1. Please use these labels when submitting a review:
    ❓ #ask: Ask a question.
    💡 #idea: Suggest an idea.
    ⚠️ #issue: Strongly suggest a change.
    🎉 #nice: Share a compliment. ↩

@xrutayisire xrutayisire requested a review from lihbr December 11, 2024 13:54
@xrutayisire xrutayisire merged commit eb32f54 into master Dec 11, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lihbr lihbr lihbr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xrutayisire @lihbr