-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support link variants #368
base: aa/refactor-link-types
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getOptionalLinkProperties
no?
For me, we should always pair text + variant together.
Either we have both or none.
Thanks, indeed I forgot to update the migration API for variants. It should be good now. 🙂 |
@xrutayisire I added a comment above prismic-client/src/types/value/link.ts Lines 88 to 89 in 8217ae6
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## aa/refactor-link-types #368 +/- ##
=========================================================
Coverage ? 99.84%
=========================================================
Files ? 76
Lines ? 3207
Branches ? 658
=========================================================
Hits ? 3202
Misses ? 5
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Resolves: #365
Description
This PR re-implements #365 based on #367.
Checklist
Preview
How to QA 1
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩