Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support link variants #368

Open
wants to merge 9 commits into
base: aa/refactor-link-types
Choose a base branch
from

Conversation

angeloashmore
Copy link
Member

@angeloashmore angeloashmore commented Dec 17, 2024

Resolves: #365

Description

This PR re-implements #365 based on #367.

Checklist

  • A comprehensive Linear ticket, providing sufficient context and details to facilitate the review of the PR, is linked to the PR.
  • If my changes require tests, I added them.
  • If my changes affect backward compatibility, it has been discussed.
  • If my changes require an update to the CONTRIBUTING.md guide, I updated it.

Preview

How to QA 1

Footnotes

  1. Please use these labels when submitting a review:
    ❓ #ask: Ask a question.
    💡 #idea: Suggest an idea.
    ⚠️ #issue: Strongly suggest a change.
    🎉 #nice: Share a compliment.

@angeloashmore angeloashmore marked this pull request as ready for review December 17, 2024 02:49
Copy link
Contributor

@xrutayisire xrutayisire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ It's missing the update of getOptionalLinkProperties no?

For me, we should always pair text + variant together.
Either we have both or none.

@angeloashmore angeloashmore mentioned this pull request Dec 17, 2024
4 tasks
@angeloashmore
Copy link
Member Author

angeloashmore commented Dec 17, 2024

@xrutayisire: ⚠️ It's missing the update of getOptionalLinkProperties no?

For me, we should always pair text + variant together. Either we have both or none.

Thanks, indeed I forgot to update the migration API for variants. It should be good now. 🙂

@angeloashmore
Copy link
Member Author

@xrutayisire I added a comment above OptionalLinkProperties to remind devs to update getOptionalLinkProperties:

// Remember to update the `getOptionalLinkProperties()` function when updating
// this type. The function should check for every property.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (aa/refactor-link-types@8217ae6). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                    Coverage Diff                    @@
##             aa/refactor-link-types     #368   +/-   ##
=========================================================
  Coverage                          ?   99.84%           
=========================================================
  Files                             ?       76           
  Lines                             ?     3207           
  Branches                          ?      658           
=========================================================
  Hits                              ?     3202           
  Misses                            ?        5           
  Partials                          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants