Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure precipitateEvolution documentation matches the code #134

Closed
stvdwtt opened this issue Jul 1, 2019 · 1 comment
Closed

Make sure precipitateEvolution documentation matches the code #134

stvdwtt opened this issue Jul 1, 2019 · 1 comment
Assignees
@stvdwtt
Labels
Documentation: General

Comments

@stvdwtt
Copy link
Member

stvdwtt commented Jul 1, 2019

Currently, the documentation gives the standard 3rd order interpolation function but the code actually uses the standard 5th order interpolation function.

Also, the documentation includes the Landau term even though the code doesn't have it.

The documentation and the code should match. (Note this could have knock-on effects on problem 7 here: https://github.com/prisms-center/PRISMS-PF_Training_Materials/blob/master/PRISMS-PF%20Exercises.pdf)
@stvdwtt stvdwtt self-assigned this Jul 1, 2019
david-montiel-t added a commit to david-montiel-t/phaseField that referenced this issue Jun 15, 2020
@david-montiel-t
Updated precipitate evolution documentation in response to issue pris…
d889b55 
…ms-center#134
david-montiel-t added a commit that referenced this issue Jun 15, 2020
@david-montiel-t
Merge pull request #160 from david-montiel-t/master
584ae19 
Updated precipitate evolution documentation in response to issue #134
@david-montiel-t
Copy link
Contributor

Documentation has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stvdwtt stvdwtt

Labels
Documentation: General
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stvdwtt @david-montiel-t