Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update src/utils.rs methods to work on F instead of on G #32

Closed
arnaucube opened this issue Jul 13, 2023 · 0 comments
Closed

update src/utils.rs methods to work on F instead of on G #32

arnaucube opened this issue Jul 13, 2023 · 0 comments
Labels

Comments

@arnaucube
Copy link
Collaborator

SparseMatrix does not need G but just G::Scalar, thus maybe makes more sense to abstract it around F instead of aroung G.

This also applies to the rest of methods of SparseMatrix and to the standalone methods sparse_vec_to_mle and matrix_vector_product_sparse.
In the same way that other methods of src/utils.rs are with generic F, such as dense_vec_to_mle, matrix_vector_product, etc.

This will affect also the tests, where instead of for example
test_matrix_vector_product_sparse_with<G: Group>()
it could be
test_matrix_vector_product_sparse_with<F: PrimeField>()

@arnaucube arnaucube added the good first issue Good for newcomers label Jul 13, 2023
@oskarth oskarth closed this as completed Jul 14, 2023
hero78119 pushed a commit to hero78119/SuperNova that referenced this issue Jan 3, 2024
* Clean up Microsoft licensing

* Add third party licenses

Cherry-picked from 6692fed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants