fix: Address all Clippy suggestions/lints #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskarth
approved these changes
Jul 14, 2023
hero78119
pushed a commit
to hero78119/SuperNova
that referenced
this pull request
Jan 3, 2024
…caling-explorations#36) * add tracing spans * more instrumenting * more tracing * use spans ig * more spans * more spans * commit_T spans 🤔 * nice spans * remove commit_T * Add trace for ppsnark and snark * fix cargo.toml and fmt --------- Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in previous CI runs:
The clippy job is causing the CI to fail due to missing fixes on the code.
This gets up to speed the codebase with Clippy recommendations and leaves the Uppercase warning disabled.
Resolves: #35