Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use gatekeeper per poll #1961

Merged
merged 1 commit into from
Dec 18, 2024
Merged

feat: use gatekeeper per poll #1961

merged 1 commit into from
Dec 18, 2024

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Dec 9, 2024

Description

Use a gatekeeper per each poll so that each can have its own gatekeeping (maci level more general, poll more specific)

Related issue(s)

fix #1858

Confirmation

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview Dec 18, 2024 4:02pm

@ctrlc03 ctrlc03 self-assigned this Dec 9, 2024
@ctrlc03 ctrlc03 force-pushed the feat/custom-gatekeeper-per-poll branch from f7cb76f to c5afb87 Compare December 9, 2024 15:42
packages/contracts/contracts/MACI.sol Dismissed Show dismissed Hide dismissed
packages/contracts/contracts/MACI.sol Dismissed Show dismissed Hide dismissed
packages/contracts/contracts/Poll.sol Dismissed Show dismissed Hide dismissed
packages/contracts/contracts/Poll.sol Dismissed Show dismissed Hide dismissed
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks, just one suggestion.

packages/contracts/tasks/deploy/poll/01-gatekeepers.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@kittybest kittybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just left a comment.
btw, I'm curious about if this PR would affect the user need to signup to each poll everytime? would it be possible that some polls wanna share the same signup information, only few of them wanna have their own gatekeeper? or is this because of the anon poll joining?
Just thinking about if one wanna attend 10 polls of a single event (let's say Devcon, for example), maybe the user don't want to sign up 10 times?

packages/cli/ts/commands/deployPoll.ts Show resolved Hide resolved
@ctrlc03
Copy link
Collaborator Author

ctrlc03 commented Dec 11, 2024

only few of them wanna have their own gatekeeper

yes correct, in most cases this might be free for all

or is this because of the anon poll joining

Yes The poll joining is for the anon poll joining flow, so that you can join with a new anonymous key for each poll

Just thinking about if one wanna attend 10 polls of a single event (let's say Devcon, for example), maybe the user don't want to sign up 10 times?

that might change in the future but will need some re-design, for now it can be made as smooth as possible to avoid affecting UX

Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks!

@ctrlc03 ctrlc03 force-pushed the feat/custom-gatekeeper-per-poll branch from a711d44 to d78e477 Compare December 18, 2024 16:00
@ctrlc03 ctrlc03 enabled auto-merge (squash) December 18, 2024 16:00
@ctrlc03 ctrlc03 merged commit 8e1ab15 into dev Dec 18, 2024
22 checks passed
@ctrlc03 ctrlc03 deleted the feat/custom-gatekeeper-per-poll branch December 18, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Custom gatekeeper per poll
3 participants