-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use gatekeeper per poll #1961
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
f7cb76f
to
c5afb87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ctrlc03 thanks, just one suggestion.
c5afb87
to
c858577
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just left a comment.
btw, I'm curious about if this PR would affect the user need to signup to each poll everytime? would it be possible that some polls wanna share the same signup information, only few of them wanna have their own gatekeeper? or is this because of the anon poll joining?
Just thinking about if one wanna attend 10 polls of a single event (let's say Devcon, for example), maybe the user don't want to sign up 10 times?
yes correct, in most cases this might be free for all
Yes The poll joining is for the anon poll joining flow, so that you can join with a new anonymous key for each poll
that might change in the future but will need some re-design, for now it can be made as smooth as possible to avoid affecting UX |
c858577
to
43aabbf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ctrlc03 thanks!
43aabbf
to
93fd8cf
Compare
93fd8cf
to
a711d44
Compare
a711d44
to
d78e477
Compare
Description
Use a gatekeeper per each poll so that each can have its own gatekeeping (maci level more general, poll more specific)
Related issue(s)
fix #1858
Confirmation