-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Change Nijmegen logo #21
feat: Change Nijmegen logo #21
Conversation
Changes the logo for gemeente Nijmegen to the image-mark version.
No issues were found when running |
@joostvanderborg the app shows logos in circular form. Therefore the content ideally fits in a circle with a diameter of the size of the image. I looks like the logo you provided will get cut off on the sides and the top. To fix this you could make the logo inside the square a little bit smaller and center it horizontally and vertically. Also the optimal image size is 512x512px. |
No issues were found when running |
@bobhageman Thanks for the feedback. I've added a commit with a modified image, 512x512, I've tested with a circular overlay with a 512px diameter. That should keep the entire logo within the frame. |
Great! The updated logo will look much better in the app. One thing though: It looks like the previous version of the logo is still there and also referenced in |
No issues were found when running |
I knew I was missing something. I just removed the old logo and referenced the new one. |
No issues were found when running |
Changes the logo for gemeente Nijmegen to the image-mark version. This modifies our change created in #18 to be more appropriate in the contexts the logo will be visible.
This PR comes from a personal fork, since we cannot allow maintainer editing of a fork in our organisation http://github.com/gemeentenijmegen.
NB: I'm not sure I made the changes correctly, feel free to let me know if anything needs to be changed.