Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial attempt at a spec. #24

Merged
merged 8 commits into from
Apr 15, 2020
Merged

Initial attempt at a spec. #24

merged 8 commits into from
Apr 15, 2020

Conversation

hober
Copy link
Member

@hober hober commented Apr 11, 2020

No description provided.

@hober hober added the do not merge This PR is a work in progress and is not ready to be merged label Apr 11, 2020
@hober hober requested a review from johnwilander April 11, 2020 21:56
@hober hober self-assigned this Apr 11, 2020
@othermaciej
Copy link

Looks like a good start!

storage-access.bs Outdated Show resolved Hide resolved
storage-access.bs Outdated Show resolved Hide resolved
storage-access.bs Outdated Show resolved Hide resolved
storage-access.bs Show resolved Hide resolved
@hober hober changed the title Initial, extremely rough, and incomplete attempt at a spec. Initial attempt at a spec. Apr 14, 2020
@hober hober requested a review from ehsan April 14, 2020 18:39
@hober
Copy link
Member Author

hober commented Apr 14, 2020

Though there are a number of things left to spec, I think this is ready to go as a first draft. Please take a look, @johnwilander & @ehsan!

@hober hober removed the do not merge This PR is a work in progress and is not ready to be merged label Apr 14, 2020
@johnwilander
Copy link
Collaborator

Looks good to me!

@hober
Copy link
Member Author

hober commented Apr 14, 2020

Okay, great. @TanviHacks is going to drum up a review from someone familiar with the Gecko implementation, and assuming they think this looks okay, let's land it.

@hober hober removed the request for review from ehsan April 14, 2020 23:42
Copy link
Collaborator

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this Tess, much appreciated!

I left a bunch of inline comments, but a lot of these could be done as follow-ups or split out into issues. I don't really want to block on getting an initial take out there.

storage-access.bs Outdated Show resolved Hide resolved
storage-access.bs Outdated Show resolved Hide resolved
storage-access.bs Outdated Show resolved Hide resolved
storage-access.bs Show resolved Hide resolved
storage-access.bs Outdated Show resolved Hide resolved
storage-access.bs Outdated Show resolved Hide resolved
storage-access.bs Outdated Show resolved Hide resolved
storage-access.bs Outdated Show resolved Hide resolved
storage-access.bs Outdated Show resolved Hide resolved
storage-access.bs Show resolved Hide resolved
@annevk
Copy link
Collaborator

annevk commented Apr 15, 2020

FWIW, others from Mozilla will be able to review this over the next couple of weeks, but that shouldn't block this from merging either. Issues can/will be filed as needed. Hope that helps.

@hober
Copy link
Member Author

hober commented Apr 15, 2020

Thanks, @annevk! Changes based on your review (a couple of fixes and a lot of new issues inline) are in 507b672 & c94752f.

@hober hober merged commit e9948ab into gh-pages Apr 15, 2020
@Brandr0id
Copy link
Member

@hober thanks! Looks good as a first draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants