Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stderr to support tty (colors in errors) #21

Merged
merged 1 commit into from
May 25, 2022
Merged

fix: stderr to support tty (colors in errors) #21

merged 1 commit into from
May 25, 2022

Conversation

privatenumber
Copy link
Owner

@privatenumber privatenumber commented May 25, 2022 •
edited
Loading

Problem

stderr didn't support TTY and hence didn't support colors because it was being piped to filter out warnings

closes #16
closes #20

Changes

  • Instead of filtering the stderr, use the --require hook to overwrite the process.emit function to filter out the warnings.
  • This probably has a slight performance improvement too because it's no longer piped

Other info

I would like to add a test for this, but I'm not sure if I can because the tests run tsx in a non-TTY environment.

@privatenumber privatenumber merged commit bd3ec4a into develop May 25, 2022
@privatenumber privatenumber deleted the stderr-color branch May 25, 2022 19:43
@privatenumber
Copy link
Owner Author

🎉 This PR is included in version 3.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: stderr doesn't show colors
1 participant
@privatenumber