fix(watch): respawn process only after exit #244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| && (!runProcess.killed && runProcess.exitCode === null) | ||
| ) { | ||
| runProcess.kill(); | ||
| } |
There was a problem hiding this comment.
Can you move this logic down right after the exit handler is registered?
There was a problem hiding this comment.
@privatenumber, could you take a look? Fixing this problem would improve developer experience quite a lot
There was a problem hiding this comment.
it is a very useful feature, PTAL @privatenumber
npdev453
changed the title
|
Maintainer editing is disabled on this pull request, so I can't make changes or run tests. Closing in favor of #298 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That code cause EADDRINUSE error in 50% of restarts in watch command if port binding going fast.
Aslo impossible to get around it with graceful shutdown logic.