Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esm): resolve absolute paths #544

Merged
merged 10 commits into from
May 6, 2024
Merged

fix(esm): resolve absolute paths #544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5d7ca18
fix(tsImport): resolve specifiers that are absolute paths
fardjad May 5, 2024
18e18ce
Merge branch 'master' into fix-absolute-path-resolution
fardjad May 5, 2024
5a5ca97
fix(tsImport): resolve specifiers that are absolute paths
fardjad May 5, 2024
3ea09d0
wip
privatenumber May 5, 2024
1f43643
Merge branch 'fix-absolute-path-resolution' of github.com:fardjad/tsx…
privatenumber May 5, 2024
38d57ba
wip
privatenumber May 5, 2024
3b2553a
wip
privatenumber May 5, 2024
d8f7e20
wip
privatenumber May 5, 2024
ef5196d
wip
privatenumber May 6, 2024
54a6c95
wip
privatenumber May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/esm/hook/resolve.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ export const resolve: resolve = async (

const isPath = (
specifier.startsWith(fileProtocol)
|| path.isAbsolute(specifier)
|| isRelativePathPattern.test(specifier)
);

Expand Down
12 changes: 12 additions & 0 deletions tests/specs/smoke.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,6 +502,7 @@ export default testSuite(async ({ describe }, { tsx }: NodeApis) => {
import './js/index.js?query=123';
import './js/index';
import './js/';
import { FIXTURE_PATH };

// No double .default.default in Dynamic Import
import('./js/index.js').then(m => {
Expand Down Expand Up @@ -638,6 +639,17 @@ export default testSuite(async ({ describe }, { tsx }: NodeApis) => {
// Comment at EOF: could be a sourcemap declaration. Edge case for inserting functions here
`.trim(),
});

const importFromTs = await fixture.readFile('import-from-ts.ts', 'utf8');
const importFromTsWithAbsolutePath = importFromTs.toString().replace(
'{ FIXTURE_PATH }',
JSON.stringify(
packageType === 'module'
? new URL('js/index.js', pathToFileURL(`${fixture.path}/`)).toString()
: path.resolve(fixture.path, 'js/index.js'),
),
);
await fixture.writeFile('import-from-ts.ts', importFromTsWithAbsolutePath);
onFinish(async () => await fixture.rm());

test('import all', async ({ onTestFail }) => {
Expand Down
Loading