Add Rename Note Feature #260
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature that allows users to rename their notes in Joplin. The changes include updates to the context menu, the note editor, and the note list to support this functionality.
*Changes Made
1)Context Menu
File: src/commands/contextMenu.ts
Added a "Rename Note" option to the right-click context menu for notes.
Implemented a function to prompt the user for a new note title and update the note accordingly.
2)Note Editor
File: src/components/noteEditor.tsx
Added a "Rename" button next to the note title in the note editor.
Implemented a function to handle renaming the note when the button is clicked.
3)Note List
File: src/components/noteList.tsx
Added functionality to update the note title in the note list when it is renamed.
4)Backend Logic (Optional)
File: src/backend/noteService.ts
Provided an example implementation of backend logic to handle renaming a note.
Implementation Details
Context Menu Update: A new menu item is added to the context menu to trigger the rename prompt.
Note Editor Update: A rename button is introduced next to the note title, which prompts the user for a new title and updates the note.
Note List Update: The note list component is updated to reflect the new title when a note is renamed.
Testing
Ensure to test the following scenarios:
Right-clicking on a note and selecting "Rename Note" updates the note title correctly.
Clicking the rename button next to the note title in the note editor updates the note title.
The note title in the note list updates correctly after renaming a note.