Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom-ap #253

Merged
merged 2 commits into from
Jun 1, 2020
Merged

Remove custom-ap #253

merged 2 commits into from
Jun 1, 2020

Conversation

thalesfragoso
Copy link
Contributor

Also add the possibility to implement it in an external crate.

However, I don't think I have enough familiarity with the whole crate to properly document the made-pub methods, so I would like to request help on that one.

@thalesfragoso
Remove custom-ap
89e8ed7 
Also add the possibility to implement it in an external crate
Yatekii
Yatekii approved these changes May 31, 2020
View reviewed changes
Copy link
Member

@Yatekii Yatekii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes :)

Generally looks sound to me! I added some descriptions to the public functions. Maybe you can give me your feedback on it @thalesfragoso :)

probe-rs/src/architecture/arm/communication_interface.rs Show resolved Hide resolved
probe-rs/src/architecture/arm/communication_interface.rs Show resolved Hide resolved
probe-rs/src/architecture/arm/communication_interface.rs Show resolved Hide resolved
probe-rs/src/architecture/arm/communication_interface.rs Show resolved Hide resolved
@thalesfragoso @Yatekii
Add docs suggested in code review
f576008 
Co-authored-by: Yatekii <Yatekii@users.noreply.github.com>
@thalesfragoso thalesfragoso marked this pull request as ready for review May 31, 2020 23:42
@thalesfragoso
Copy link
Contributor Author

Thanks @Yatekii , I think this is ready now.

@Yatekii
Copy link
Member

Yatekii commented Jun 1, 2020

Thanks for doing this!

@Yatekii Yatekii merged commit f867b5c into probe-rs:master Jun 1, 2020
@thalesfragoso thalesfragoso deleted the remove-custom-ap branch July 19, 2020 02:57
Tiwalun pushed a commit that referenced this pull request Jan 13, 2023
@bors @dependabot
Merge #253
9545e9b 
253: Bump crossterm from 0.20.0 to 0.21.0 r=Yatekii a=dependabot[bot]

Bumps [crossterm](https://github.com/crossterm-rs/crossterm) from 0.20.0 to 0.21.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/crossterm-rs/crossterm/blob/master/CHANGELOG.md">crossterm's changelog</a>.</em></p>
<blockquote>
<h1>Version 0.21</h1>
<ul>
<li>Expose <code>is_raw</code> function.</li>
<li>Add 'purge' option on unix system, this clears the entire screen buffer.</li>
<li>Improve serialisation for color enum values.</li>
</ul>
<h1>Version 0.20</h1>
<ul>
<li>Update from signal-hook with 'mio-feature flag' to signal-hook-mio 0.2.1.</li>
<li>Manually implements Eq, PartialEq and Hash for KeyEvent improving equality checks and hash calculation.</li>
<li><code>crossterm::ErrorKind</code> to <code>io::Error</code>.</li>
<li>Added Cursor Shape Support.</li>
<li>Add support for function keys F13...F20.</li>
<li>Support taking any Display in <code>SetTitle</code> command.</li>
<li>Remove lazy_static dependency.</li>
<li>Remove extra Clone bounds in the style module.</li>
<li>Add <code>MoveToRow</code> command.</li>
<li>Remove writer parameter from execute_winapi</li>
</ul>
<h1>Version 0.19</h1>
<ul>
<li>Use single thread for async event reader.</li>
<li>Patch timeout handling for event polling this was not working correctly.</li>
<li>Add unix support for more key combinations mainly complex ones with ALT/SHIFT/CTRL.</li>
<li>Derive <code>PartialEq</code> and <code>Eq</code> for ContentStyle</li>
<li>Fix windows resize event size, this used to be the buffer size but is screen size now.</li>
<li>Change <code>Command::ansi_code</code> to <code>Command::write_ansi</code>, this way the ansi code will be written to given formatter.</li>
</ul>
<h1>Version 0.18.2</h1>
<ul>
<li>Fix panic when only setting bold and redirecting stdout.</li>
<li>Use <code>tty_fd</code> for set/get terminal attributes</li>
</ul>
<h1>Version 0.18.1</h1>
<ul>
<li>Fix enabling ANSI support when stdout is redirected</li>
<li>Update crossterm-winapi to 0.6.2</li>
</ul>
<h1>Version 0.18.0</h1>
<ul>
<li>Fix get position bug</li>
<li>Fix windows 8 or lower write to user-given stdout instead of stdout.</li>
<li>Make MoveCursor(Left/Right/Up/Dow) command with input 0 not move.</li>
<li>Switch to futures-core to reduce dependencies.</li>
<li>Command API restricts to only accept <code>std::io::Write</code></li>
<li>Make <code>supports_ansi</code> public</li>
<li>Implement ALT + numbers windows systems.</li>
</ul>
<h1>Version 0.17.7</h1>
<ul>
<li>Fix cursor position retrieval bug linux.</li>
</ul>
<h1>Version 0.17.6</h1>
<ul>
<li>Add functionality to retrieve color based on passed ansi code.</li>
<li>Switch from 'futures' to 'futures-util' crate to reduce dependency count</li>
<li>Mio 0.7 update</li>
<li>signal-hook update</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/crossterm-rs/crossterm/commits">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=crossterm&package-manager=cargo&previous-version=0.20.0&new-version=0.21.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Yatekii pushed a commit that referenced this pull request Jan 13, 2023
@bors @dependabot
Merge #253
5a045da 
253: Bump anyhow from 1.0.66 to 1.0.68 r=Yatekii a=dependabot[bot]

Bumps [anyhow](https://github.com/dtolnay/anyhow) from 1.0.66 to 1.0.68.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/dtolnay/anyhow/releases">anyhow's releases</a>.</em></p>
<blockquote>
<h2>1.0.68</h2>
<ul>
<li>Opt out of <code>-Zrustdoc-scrape-examples</code> on docs.rs for now</li>
</ul>
<h2>1.0.67</h2>
<ul>
<li>Improve the backtrace captured when <code>context()</code> is used on an <code>Option</code> (<a href="https://github-redirect.dependabot.com/dtolnay/anyhow/issues/280">#280</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/dtolnay/anyhow/commit/867763b8fce65656a754d8e0d84f0aa1c610613a"><code>867763b</code></a> Release 1.0.68</li>
<li><a href="https://github.com/dtolnay/anyhow/commit/c0a87d0a1fca4625dd6fcfe3e722e24214fd840e"><code>c0a87d0</code></a> Opt out -Zrustdoc-scrape-examples on docs.rs</li>
<li><a href="https://github.com/dtolnay/anyhow/commit/1cc707b6f89a2ea8eb827d0a3c3a61e2ea979366"><code>1cc707b</code></a> Release 1.0.67</li>
<li><a href="https://github.com/dtolnay/anyhow/commit/613b26115c0e5e4f988ed6e5f0eace8f79b19704"><code>613b261</code></a> Update build status badge</li>
<li><a href="https://github.com/dtolnay/anyhow/commit/0f922d7c51d43ce30421ea1225e06d971cf99bfc"><code>0f922d7</code></a> Disable backtrace CI on Rust 1.50</li>
<li><a href="https://github.com/dtolnay/anyhow/commit/acecd9bd35184ed63ff00c970f1ab41b8418a902"><code>acecd9b</code></a> Update ui test suite to nightly-2022-12-15</li>
<li><a href="https://github.com/dtolnay/anyhow/commit/0bac51f19bca58152f2310442e0aed549e54fbf7"><code>0bac51f</code></a> Time out workflows after 45 minutes</li>
<li><a href="https://github.com/dtolnay/anyhow/commit/60e88002dcf7315487cbb2c724c66d2297c7bf46"><code>60e8800</code></a> Fix renamed let_underscore_drop lint</li>
<li><a href="https://github.com/dtolnay/anyhow/commit/8d1c734b813d53669903914b79760a6668bacb6d"><code>8d1c734</code></a> Update ui test suite to nightly-2022-11-16</li>
<li><a href="https://github.com/dtolnay/anyhow/commit/451651b2ba620721f68f13dc37821592630d7e45"><code>451651b</code></a> Update ui test suite to nightly-2022-11-11</li>
<li>Additional commits viewable in <a href="https://github.com/dtolnay/anyhow/compare/1.0.66...1.0.68">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=anyhow&package-manager=cargo&previous-version=1.0.66&new-version=1.0.68)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
burrbull pushed a commit to burrbull/probe-rs that referenced this pull request Feb 27, 2023
@bors
Merge probe-rs#253
73ba0cc 
253: feat: add help message for JtagNoDeviceConnected r=Urhengulas a=numero-744

Hello!

I had the `JtagNoDeviceConnected` error and did not know what to do, and someone in the Rust Embedded matrix channel told me that it happens to a lot of people. So maybe `probe-run` could print some help in this case. This is what this PR does.

```
% cargo run --bin=blinky
    Finished dev [unoptimized + debuginfo] target(s) in 0.17s
     Running `/home/*****/Development/probe-run/target/debug/probe-run --chip STM32F407VGTx target/thumbv7em-none-eabi/debug/blinky`
Info: Jtag cannot find a connected device.
Help:
    Try using probe-run with option `--connect-under-reset`
    Or if using cargo:
        cargo run -- --connect-under-reset
    This error comes from the program currently in the chip and
    using `--connect-under-reset` is only a workaround.

Error: An error specific to a probe type occured

Caused by:
    Command failed with status JtagNoDeviceConnected
```

This PR is just to show the idea, I can refactor it as needed.

In the matrix channel was also discussed the possibility to:

- enable the flag automatically when the error occurs, which can be done while printing a warning, and/or
- add a link to an explanation of the reason why this error occurs and how to avoid it in the future

Refactoring of this PR would enable to add help for the user about more various kinds of errors.

Co-authored-by: Côme ALLART <come.allart@etu.emse.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yatekii Yatekii Yatekii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thalesfragoso @Yatekii