Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert launch.json properties to camelCase #21

Merged
merged 2 commits into from
Nov 12, 2021
Merged

Convert launch.json properties to camelCase #21

merged 2 commits into from
Nov 12, 2021

Conversation

noppej
Copy link
Contributor

@noppej noppej commented Nov 12, 2021

Note: The changes in this PR is dependent on being synchronized with probe-rs PR #885

Changes

  • Convert all existing launch.json properties to camelCase
  • Updates to README

@noppej noppej linked an issue Nov 12, 2021 that may be closed by this pull request
@noppej noppej marked this pull request as ready for review November 12, 2021 15:43
Copy link
Member

@Tiwalun Tiwalun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for changing this!

I have some comments on the README changes, but the actual code all looks good 👍

README.md Outdated

### Updating the GitHub release page
After any PR has been merged, you need to consider if it is necessary to update the `.vsix` in the repository's [release page](https://github.com/probe-rs/vscode/releases).
* For minor fixes and changes, just update the asset for the latest release.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should always create a new release, updating an existing release can be very confusing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can align with that. Ideally I'd like bors to compile and create the release, but I don't know enough about bors to automate that.

README.md Outdated
Comment on lines 24 to 23
```bash
code --install-extension amodio.tsl-problem-matcher
```
- Install the extensions VS Code recommends
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like doing this on the command line, since it is also used in the previous steps. Maybe we can just say something like "Install the recommended extensions in VS Code, or run the following command line: "?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would work, but then we'd have to update this README every time we have some new extension required (like the discussions about enforcing code formatting. I have a suggestion that might help both of us. Let me push into this PR and you can see if you are OK with it.

bors bot added a commit to probe-rs/probe-rs that referenced this pull request Nov 12, 2021
885: Convert `launch.json` properties to camelCase r=Yatekii a=noppej

*Note:* The changes in this PR is dependent on being synchronized with [probe-rs/vscode PR #21](probe-rs/vscode#21)

*Changes*
* Convert all existing `launch.json` properties to camelCase
* Updates to CHANGELOG

Co-authored-by: JackN <noppej@hotmail.com>
@noppej noppej requested a review from Tiwalun November 12, 2021 17:42
Copy link
Member

@Tiwalun Tiwalun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 12, 2021

@bors bors bot merged commit a35df1b into master Nov 12, 2021
@bors bors bot deleted the noppej/issue17 branch November 12, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistent config key style
2 participants