Disable deep watcher on $props

[romansp]

Fixes #27.

This PR tries to mitigate issue by dropping deep: true from watcher and provides another way to handle props updates to be passed correctly to Moveable instance.

[romansp]

@probil This is somewhat work in progress. Not sure what scope of changes you expect in this PR. I really like you approach to deep-watching described here: #27 (comment)

I guess it also implies that component props themselves will be constructed dynamically? But in this case not sure how to handle type-checks. Maybe drop $props altogether and switch to $attrs?

Few tests will also be a cool addition to that.

Should I implement all of it in this PR, or open another one?

[probil]

Hi @romansp

The scope of this PR is to fix Maximum call stack size exceeded and keep existing functionality in place.

I think you can simplify it a bit for now.

const watchReactiveProp = key => function (newValue) {
  const existingValue = this.moveable[key]; 
  if (existingValue === newValue) return; 
  this.moveable[key] = newValue; 
}

export default {
  // ...
  watch: {
      draggable: watchReactiveProp('draggable'),
      resizable: watchReactiveProp('resizable'),
      scalable: watchReactiveProp('scalable'),
      rotatable: watchReactiveProp('rotatable'),
      warpable: watchReactiveProp('warpable'),
      pinchable: watchReactiveProp('pinchable'),
      origin: watchReactiveProp('origin'),
      throttleDrag: watchReactiveProp('throttleDrag'),
      throttleResize: watchReactiveProp('throttleResize'),
      throttleScale: watchReactiveProp('throttleScale'),
      throttleRotate: watchReactiveProp('throttleRotate'),
      keepRatio: watchReactiveProp('keepRatio'),
  }
}

I'll merge and then we can figure out how to make it more maintainable

[romansp]

Okay, I updated PR. Changed to something that's closer to #27 (comment).

[probil]

Remove [WIP] prefix when it's ready for review & merge

[probil]

I don't think we need deep here 🤔 There is only one prop that can be an array
But let it be.

[romansp]

Absolutely agree, I decided to implement it in this way to accommodate for future upgrade to newer versions of Movable, so we don't have to think about changes in underlying API.