fix(appimaged): avoid 'Invalid desktop file' error on Debian

[Cobraeti]

This change should fix #273

[CalebQ42]

It's better to use filepath.Join instead of string concatenation to make sure there aren't any double slashes.

[Cobraeti]

I'm out this afternoon, I will try to make this rework tomorrow, thanks for the head-up 😉

[Cobraeti]

Hi @CalebQ42, I just pushed the rework and also added surrounding quotes in case os.UserHomeDir could contain spaces (even if I hope this won't happen anywhere 😅)

[Cobraeti]

I will check why the pipeline failed, but that might take a while, as I don't have a Go environnement setup ATM 😅

[Cobraeti]

After reading the pipeline error a few more times I think I figured the error => I passed the already concacenated string instead of a list of strings...
I hope that's enough to build, else I will really need to setup this Go environnement and check all build steps on my side to avoid bothering you 😅

[CalebQ42]

I've been a bit busy so I didn't catch it initially, but os.UserHomeDir() returns two values so you can't inline it. Instead you'll need to set the values to a variable before you can use it.

[Cobraeti]

Hi @CalebQ42, I took the time to setup GoLand and it helped me even notice that a variable home catching the good part of os.UserHomeDir() was already defined in the main package:

go-appimage/src/appimaged/appimaged.go

Line 76 in 09fd018

var home, _ = os.UserHomeDir()

I'm not sure if it's a good practice though, but I was able to compile and push it on my target system to confirm the error is now gone...

Just in case, as I was not able to replicate the exact context of the Github Workflow to build:

• Build system: Ubuntu 22.04.1 (running through WSL2) + go version go1.18.1 linux/amd64
• Build command: ./scripts/build.sh -a amd64,386,arm64,arm appimaged (I was not able to build the full project)

[probonopd]

Thank you very much @Cobraeti