Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: replace @pika/build with esbuild and tsc #238

Merged
merged 2 commits into from
Sep 28, 2023
Merged

build: replace @pika/build with esbuild and tsc #238

merged 2 commits into from
Sep 28, 2023

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Sep 28, 2023 •
edited by gr2m
Loading

@gr2m

I would like to update probot to use latest node. For this I would like to update this package.

BREAKING CHANGE: drop support for Node < 18

gr2m
gr2m reviewed Sep 28, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Sep 28, 2023

@gr2m

I tried to contact you on discord and twitter. Is there a chat opportunity to coordinate the necessary changes?

@gr2m
Copy link
Contributor

gr2m commented Sep 28, 2023 •
edited by unfurl-links bot
Loading

I would like to keep the discussion here if you don't mind. I get notifications and will prioritize the one for this pull request.

For general @probot questions you can also start a discussion here: https://github.com/probot/probot/discussions/. There is some increased interest in Probot both from within GitHub and from the outside, it's a good time to get involved if you are interested. If you are interested let me know, I'll reach out if we do any maintainer onboarding calls in near future

GitHub
Explore the GitHub Discussions forum for probot probot. Discuss code, ask questions & collaborate with the developer community.

Uzlopak
Uzlopak commented Sep 28, 2023
View reviewed changes
package.json
"@types/jest": "^29.0.0",
"@types/node": "^18.7.15",
"esbuild": "^0.19.4",
"fetch-mock": "^9.11.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I also use npm:@gr2m/fetch-mock@9.11.0-pull-request-644.1

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Sep 28, 2023

@gr2m
I used app.js as a blueprint for this PR. I hope it covers everything.

gr2m
gr2m approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you so much @Uzlopak

@gr2m gr2m changed the title update octokit and drop eol node versions support build: replace @pika/build with esbuild and tsc Sep 28, 2023
@gr2m gr2m merged commit ba8a02e into probot:main Sep 28, 2023
4 checks passed
@github-actions
Copy link

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Uzlopak Uzlopak deleted the drop-16 branch September 28, 2023 19:10
@Uzlopak Uzlopak restored the drop-16 branch September 28, 2023 19:37
@WontonSam WontonSam mentioned this pull request Sep 10, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Uzlopak @gr2m