Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace glob with globby and make it dev-only #244

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

AaronDewes
Copy link
Member

glob has dependencies which aren't OSI-approved, so replace it with globby to have a fully FOSS dev environment.

Also, it was moved to a devDependency as it does not seem to be used at runtime.

package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it Locally. Same output as we did with glob.
LGTM

@Uzlopak
Copy link
Contributor

Uzlopak commented Nov 13, 2023

@wolfy1339
@gr2m

PTAL

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, cheers!

@gr2m gr2m enabled auto-merge (squash) November 14, 2023 05:50
@gr2m gr2m merged commit e4d8b63 into probot:main Nov 14, 2023
4 checks passed
Copy link

🎉 This PR is included in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants