Example pages codeblock keyboard trap fix

[katlich112358]

Fixes #1372

Changes:
Ace.js recently added a way to prevent keyboard trapping (ajaxorg/ace#5114). This PR updates the ace.js files within p5's repo to their v1.5.0 version (https://github.com/ajaxorg/ace-builds/releases/tag/v1.5.0) and enables the keyboard accessibility features for code blocks.

[Qianqianye]

Thanks @katlich112358 for working on it and @paulaxisabel for reviewing it. Hey @calebfoss, can you review this PR as well? We will merge this PR when it's approved by at least 2 mentors/maintainers. Thanks!

[calebfoss]

I'm seeing this error when opening the reference page:

Uncaught TypeError: DocumentedMethod is not a constructor        [reference.js:4920:16]

Not sure why, and I can take a closer look later.

[calebfoss]

I'm stumped on that error. I'm not seeing the relationship between it and the files changed, but it is only thrown when these changes are applied. I'm not seeing Ace referenced in the reference.js file at all. Can someone more familiar with how reference.js works take a look at see if there are any clues?

[nickmcintyre]

@calebfoss @katlich112358 I just saw this error as well and managed to fix it locally. I used the most recent ace-builds to replace the following:

• src/assets/js/vendor/ace with the contents of src-min
• src/assets/js/vendor/ace-nc with the contents of src-min-noconflict

I don't actually understand why that worked. Probably an issue with the other ace files in those directories.

[nickmcintyre]

@katlich112358 I believe you just need to update the remaining ace files in src/assets/js/vendor/ace and src/assets/js/vendor/ace-nc with the most recent versions from ace-builds

[katlich112358]

@nickmcintyre Great, thanks! Just to be sure I'm reading this correctly, replace the entire ace and ace-nc folders with the newer ace.js content? Or just the files that exist within p5's directory?

[nickmcintyre]

@katlich112358 good clarification. I only replaced the files that exist within p5's directory.

Minor tangent:

I just skimmed default.hbs and it looks like ace-nc/ace.js and ace-nc/mode-javascript.js are the only ace.js files that are actually used. Just deleted the ace folder and everything in ace-nc except for the new ace.js and mode-javascript.js files. The site seems to work fine with only these files.

[limzykenneth]

Just want to check, is this ready for review and merging?

[katlich112358]

@limzykenneth I believe so, yep!

[limzykenneth]

Looks good. Thanks!