Make sure setAttributes updates lingering references to the old canvas #5824
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5817
Changes
Previously, when
setAttributes
creates a new canvas, it wouldn't update thecanvas
property of the renderer, leaving a reference to the old canvas. Now, when it's set correctly, sketches that try to read back the main canvas via a reference to a renderer will see the contents of the canvas instead of a blank canvas.Screenshots of the change
Before:
setAttributes({ alpha: true })
tosetup
After:
PR Checklist
npm run lint
passes