Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure setAttributes updates lingering references to the old canvas #5824

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

davepagurek
Copy link
Contributor

Resolves #5817

Changes

Previously, when setAttributes creates a new canvas, it wouldn't update the canvas property of the renderer, leaving a reference to the old canvas. Now, when it's set correctly, sketches that try to read back the main canvas via a reference to a renderer will see the contents of the canvas instead of a blank canvas.

Screenshots of the change

Before:

image

After:

image

PR Checklist

  • npm run lint passes
  • [Inline documentation] is included / updated
  • [Unit tests] are included / updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants