Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove body match requirement from approved reviews #15

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Conversation

klutchell
Copy link
Collaborator

@klutchell klutchell commented Dec 8, 2024

If the changes are approved for merge, there is no need to also provide
the /deploy string in the body.

@deploynaut-testing
Copy link

One or more environments require approval before deploying workflow runs.

Maintainers, please inspect changes carefully for improper handling of sensitive information and submit a review with the required string.

Files changed -> Review changes -> Comment -> /deploy

1 similar comment
@deploynaut-testing
Copy link

One or more environments require approval before deploying workflow runs.

Maintainers, please inspect changes carefully for improper handling of sensitive information and submit a review with the required string.

Files changed -> Review changes -> Comment -> /deploy

@klutchell
Copy link
Collaborator Author

@ab77 @rcooke-warwick can I get another review here please?

Copy link
Collaborator Author

@klutchell klutchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/deploy

Change-type: patch
Signed-off-by: Kyle Harding <kyle@balena.io>
If the changes are approved for merge, there is no need to also provide
the /deploy string in the body.

Change-type: patch
Signed-off-by: Kyle Harding <kyle@balena.io>
Copy link
Contributor

@rcooke-warwick rcooke-warwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/deploy

@flowzone-app flowzone-app bot merged commit d26ad96 into main Dec 9, 2024
56 checks passed
@flowzone-app flowzone-app bot deleted the develop branch December 9, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants