feat: Improved selectors-format rule to forbid optional arguments

resolves #65
productboardlabs · Apr 1, 2020 · da6ba32 · da6ba32
1 parent e2d805e
commit da6ba32
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 0 deletions.
diff --git a/README.md b/README.md
@@ -225,6 +225,12 @@ select(
    ~~~~~~~~~~~~~~            [Default arguments are forbidden.]
 );
 
+select(
+  [Store],
+  (a?: number) => false,
+   ~~~~~~~~~~                [Optional arguments are forbidden.]
+);
+
 select(
   [Store],
   (abc, xyz) => false,

diff --git a/src/rules/selectorsFormatRule.ts b/src/rules/selectorsFormatRule.ts
@@ -118,6 +118,13 @@ class SelectorsFormatRule extends Lint.RuleWalker {
         );
       }
 
+      if (paramNode.questionToken) {
+        this.addFailureAtNode(
+          paramNode,
+          this.getFormattedError('Optional arguments are forbidden.'),
+        );
+      }
+
       if (!paramNode.type) {
         this.addFailureAtNode(
           paramNode,

diff --git a/test/rules/selectors-format/test.2.tsx.lint b/test/rules/selectors-format/test.2.tsx.lint
@@ -45,6 +45,12 @@ select(
    ~~~~~~~~~~~~~~            [Default arguments are forbidden.]
 );
 
+select(
+  [Store],
+  (a?: number) => false,
+   ~~~~~~~~~~                [Optional arguments are forbidden.]
+);
+
 select(
   [Store],
   (abc, xyz) => false,