Skip to content
This repository has been archived by the owner on Oct 6, 2020. It is now read-only.

Allow recursive selectors and correctly watch for Identifier and PropertyAccessExpression #38

Merged
merged 2 commits into from
May 1, 2019
Merged

Allow recursive selectors and correctly watch for Identifier and PropertyAccessExpression #38

merged 2 commits into from
May 1, 2019

Conversation

jukben
Copy link
Contributor

@jukben jukben commented Apr 30, 2019

close #37
close #36

@jukben jukben requested a review from mauricekleine April 30, 2019 16:07
@jukben jukben changed the title Fix/check unused flux dependenices minor issues Allow recursive selectors and correctly watch for Identifier and PropertyAccessExpression May 1, 2019
mauricekleine
mauricekleine approved these changes May 1, 2019
View reviewed changes
Copy link
Contributor

@mauricekleine mauricekleine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Those ts.is... functions really boost readability, awesome!

@jukben
Copy link
Contributor Author

jukben commented May 1, 2019 •
edited
Loading

Yep, agree #33 fully introduced them, before there were just in one (the newest) place. #34 there is an refactor issue for it 💪

@jukben jukben merged commit d407344 into master May 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mauricekleine mauricekleine mauricekleine approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ignore properties (just the expression should be watched) Recursive selector is fine
2 participants
@jukben @mauricekleine