Skip to content
This repository has been archived by the owner on Oct 6, 2020. It is now read-only.

Open-sourced Correct React Import rule #58

Merged
merged 1 commit into from
Jul 1, 2019
Merged

Conversation

jukben
Copy link
Contributor

@jukben jukben commented Jun 28, 2019

In order to remove custom rules from internal codebase (to avoid building them in post-install step), let's open source this rule since it might be useful for other as well.

@jukben jukben requested review from Aldredcz and mauricekleine June 28, 2019 13:49
@jukben jukben force-pushed the feat/correct-react-import branch from 6d04153 to 3af26e0 Compare June 28, 2019 13:51
@jukben jukben force-pushed the feat/correct-react-import branch from 3af26e0 to e371464 Compare July 1, 2019 08:38
Copy link
Contributor

@mauricekleine mauricekleine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! My only worry was the specific check for 'React' module name, but the latests fix is perfect! 😄

@jukben jukben force-pushed the feat/correct-react-import branch from e371464 to a3accb3 Compare July 1, 2019 09:27
@jukben jukben merged commit c1adf0b into master Jul 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants