Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev 18195 #12

Merged
merged 15 commits into from
Aug 6, 2024
Merged

Dev 18195 #12

merged 15 commits into from
Aug 6, 2024

Conversation

khelmrich
Copy link
Contributor

Main codebase without test. Next PR will be with tests

@private-packagist Private Packagist
Copy link

private-packagist bot commented Aug 2, 2024 •
edited
Loading

composer.lock

Click to show 56 changes in this composer.lock file

Package changes

Package Operation From To About
async-aws/core add - 1.22.0 view code - changelog - License: MIT License
async-aws/s3 add - 2.3.0 view code - changelog - License: MIT License
aws/aws-crt-php add - v1.2.6 view code - changelog - License: Apache License 2.0
aws/aws-sdk-php add - 3.317.2 view code - changelog - License: Apache License 2.0
league/flysystem add - 3.28.0 view code - changelog - License: MIT License
league/flysystem-async-aws-s3 add - 3.28.0 view code - License: MIT License
league/flysystem-aws-s3-v3 add - 3.28.0 view code - changelog - License: MIT License
league/flysystem-bundle add - 3.3.5 view code - changelog - License: MIT License
league/flysystem-local add - 3.28.0 view code - License: MIT License
league/mime-type-detection add - 1.15.0 view code - changelog - License: MIT License
mtdowling/jmespath.php add - 2.7.0 view code - changelog - License: MIT License
symfony/http-client add - v7.0.10 view code - changelog - License: MIT License
symfony/http-client-contracts add - v3.5.0 view code - changelog - License: MIT License
guzzlehttp/guzzle upgrade 7.8.1 7.9.2 diff - changelog
guzzlehttp/promises upgrade 2.0.2 2.0.3 diff - changelog
guzzlehttp/psr7 upgrade 2.6.2 2.7.0 diff - changelog
jane-php/json-schema upgrade v7.8.0 v7.8.1 diff - changelog
jane-php/json-schema-runtime upgrade v7.8.0 v7.8.1 diff - changelog
jane-php/open-api-3 upgrade v7.8.0 v7.8.1 diff
jane-php/open-api-common upgrade v7.8.0 v7.8.1 diff
jane-php/open-api-runtime upgrade v7.8.0 v7.8.1 diff
productsupcom/lib-dk-testing upgrade 0.0.8 0.0.10 diff - changelog
symfony/cache upgrade v7.0.7 v7.0.10 diff - changelog
symfony/clock upgrade v7.0.7 v7.0.8 diff - changelog
symfony/config upgrade v7.0.7 v7.0.8 diff - changelog
symfony/console upgrade v7.0.7 v7.0.10 diff - changelog
symfony/dependency-injection upgrade v7.0.7 v7.0.10 diff - changelog
symfony/dotenv upgrade v7.0.7 v7.0.10 diff - changelog
symfony/error-handler upgrade v7.0.7 v7.0.10 diff - changelog
symfony/event-dispatcher upgrade v7.0.7 v7.0.8 diff - changelog
symfony/filesystem upgrade v7.0.7 v7.0.9 diff - changelog
symfony/finder upgrade v7.0.7 v7.0.10 diff - changelog
symfony/framework-bundle upgrade v7.0.7 v7.0.10 diff - changelog
symfony/http-foundation upgrade v7.0.7 v7.0.10 diff - changelog
symfony/http-kernel upgrade v7.0.7 v7.0.10 diff - changelog
symfony/messenger upgrade v7.0.7 v7.0.10 diff - changelog
symfony/options-resolver upgrade v7.0.7 v7.0.8 diff - changelog
symfony/routing upgrade v7.0.7 v7.0.10 diff - changelog
symfony/runtime upgrade v7.0.7 v7.0.8 diff - changelog
symfony/serializer upgrade v7.0.7 v7.0.10 diff - changelog
symfony/string upgrade v7.0.7 v7.0.10 diff - changelog
symfony/validator upgrade v7.0.7 v7.0.10 diff - changelog
symfony/var-dumper upgrade v7.0.7 v7.0.10 diff - changelog
symfony/var-exporter upgrade v7.0.7 v7.0.9 diff - changelog
symfony/yaml upgrade v7.0.7 v7.0.8 diff - changelog
symfony/process remove v7.0.7 - -

Dev Package changes

Package Operation From To About
symfony/process add - v7.0.8 view code - changelog - License: MIT License
composer/pcre upgrade 3.1.4 3.2.0 diff - changelog
composer/semver upgrade 3.4.0 3.4.2 diff - changelog
friendsofphp/php-cs-fixer upgrade v3.59.3 v3.61.1 diff - changelog
phpstan/phpstan upgrade 1.11.7 1.11.9 diff - changelog
phpunit/phpunit upgrade 10.5.27 10.5.29 diff - changelog
react/socket upgrade v1.15.0 v1.16.0 diff - changelog
roave/security-advisories upgrade dev-latest c31e886 dev-latest ff74569 diff
symfony/phpunit-bridge upgrade v7.0.9 v7.0.10 diff - changelog
symfony/stopwatch upgrade v7.0.7 v7.0.8 diff - changelog

Add your project as a package to Private Packagist to benefit from security monitoring of your dependencies.

Settings · Docs · Powered by Private Packagist

@swarmia Swarmia
Copy link

swarmia bot commented Aug 2, 2024

✅  Linked to Story DEV-18195 · Import S3 Parquet File Format

@codacy-production Codacy Production
Copy link

codacy-production bot commented Aug 2, 2024 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.00% (target: -1.00%) ✅ 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0d7bb2e) 9 0 0.00%
Head commit (4e95045) 49 (+40) 0 (+0) 0.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#12) 41 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@khelmrich khelmrich marked this pull request as ready for review August 2, 2024 13:09
@khelmrich khelmrich requested review from a team as code owners August 2, 2024 13:09
jacekgadomski
jacekgadomski requested changes Aug 5, 2024
View reviewed changes
Copy link

@jacekgadomski jacekgadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, some minor things to fix

Dockerfile Show resolved Hide resolved
config/services.yaml Show resolved Hide resolved
src/Import/Application/Importer.php Outdated Show resolved Hide resolved
src/Import/Domain/DuckDb/FileConverter.php Outdated Show resolved Hide resolved
src/Import/Infrastructure/Transporter/Exception/ConnectionException.php Outdated Show resolved Hide resolved
src/Import/Infrastructure/Transporter/Exception/ConnectionException.php Outdated Show resolved Hide resolved
src/Import/Infrastructure/Transporter/Exception/DownloadFailed.php Show resolved Hide resolved
src/Import/Infrastructure/Transporter/Factory/FilesystemFactory.php Outdated Show resolved Hide resolved
@private-packagist Private Packagist
Copy link

The composer.lock diff comment has been updated to reflect new changes in this PR.

@private-packagist Private Packagist
Copy link

The composer.lock diff comment has been updated to reflect new changes in this PR.

jacekgadomski
jacekgadomski approved these changes Aug 6, 2024
View reviewed changes
.env
@@ -1 +1,6 @@
APP_ENV=prod
FILE_NAME=
AWS_ACCESS_KEY_ID=
AWS_SECRET_ACCESS_KEY=
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rememeber to add this as a secret in the connector config

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will :)

config/services.yaml Show resolved Hide resolved
src/Import/Infrastructure/Transporter/Exception/DownloadFailed.php Show resolved Hide resolved
@khelmrich khelmrich merged commit cb9cb31 into main Aug 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacekgadomski jacekgadomski jacekgadomski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khelmrich @jacekgadomski