Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev 18195 add tests #15

Merged
merged 4 commits into from
Aug 13, 2024
Merged

Dev 18195 add tests #15

merged 4 commits into from
Aug 13, 2024

Conversation

khelmrich
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change. And don't forget to add the related Jira Issue ID (e.g.
DEV-7327). Swarmia adding then automatically the link to the PR.

Checklist:

  • All acceptance criteria/requirements are met
  • New/updated functionality is covered by tests
  • All tests have been successfully run
  • CI run has passed all checks
  • My code follows the style guidelines of this project
  • Any dependent changes have been merged and released in downstream modules
  • Single feature has passed QA on local environment
  • The initial request has approved/reviewed changes

@khelmrich khelmrich requested review from a team as code owners August 13, 2024 11:29
Copy link

codacy-production bot commented Aug 13, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+61.22% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1c2565e) 49 0 0.00%
Head commit (81dba91) 49 (+0) 30 (+30) 61.22% (+61.22%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#15) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

swarmia bot commented Aug 13, 2024

✅  Linked to Story DEV-18195 · Import S3 Parquet File Format

@khelmrich khelmrich merged commit d750111 into main Aug 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants