fix(kubectl): better support for get profile timerange #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed #37 There is still a bug in profefe to fix profefe/profefe#82 Now you can use: ```bash kubectl profefe get profiles --service frontend --profile-type goroutine --from -20m ``` To get the last 20 minutes of goroutine profiles for the service frontend. Or you can use `--to` as well to specify when to stop the research ```bash kubectl profefe get profiles --service auth --profile-type goroutine --from -2h --to -1h ``` It also support a fixed timerange in RFC3339 format ```bash kubectl profefe get profiles --service query --profile-type goroutine --from "2019-10-12T07:20:50.52Z" --to "2019-10-13T07:20:50.52Z" ``` Time is converted to UTC. Signed-off-by: Gianluca Arbezzano <gianarb92@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #37
There is still a bug in profefe to fix profefe/profefe#82
Now you can use:
To get the last 20 minutes of goroutine profiles for the service
frontend.
Or you can use
--toas well to specify when to stop the researchIt also support a fixed timerange in RFC3339 format
Time is converted to UTC.
Signed-off-by: Gianluca Arbezzano gianarb92@gmail.com