fix(kubectl): krew action does not work #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianarb
added
bug
|
ok I looked more closely. it can be fixed by adding 'indent 6' at the end. e.g. |
The currently deployed release workflow does not work. The template file for krew does not get translated correctly. This is an attempt to fix this issue ``` 11:42 $ docker run -v $PWD/.krew/profefe.yaml:/tmp/template-file.yaml rajatjindal/krew-release-bot:v0.0.37 krew-release-bot template --tag v0.3.0 --template-file /tmp/template-file.yaml > /tmp/ciao time="2020-04-05T09:43:35Z" level=info msg="getting sha256 for https://github.com/profefe/kube-profefe/releases/download/v0.3.0/kube-profefe_v0.3.0_Darwin_x86_64.tar.gz" time="2020-04-05T09:44:03Z" level=info msg="downloaded file /tmp/266050939/1586079815" time="2020-04-05T09:44:03Z" level=info msg="getting sha256 for https://github.com/profefe/kube-profefe/releases/download/v0.3.0/kube-profefe_v0.3.0_Linux_x86_64.tar.gz" time="2020-04-05T09:44:40Z" level=info msg="downloaded file /tmp/965187230/1586079843" time="2020-04-05T09:44:40Z" level=fatal msg="failed to get plugin name from processed template.\nerr: error converting YAML to JSON: yaml: line 19: did not find expected '-' indicator" ``` Signed-off-by: Gianluca Arbezzano <gianarb92@gmail.com>
gianarb
force-pushed
the
fix/krew-release-action
branch
from
77a7464 to
a5fbf44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The currently deployed release workflow does not work. The template file
for krew does not get translated correctly.
This is an attempt to fix this issue
Signed-off-by: Gianluca Arbezzano gianarb92@gmail.com