Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash Expiration commands for redis 7.4.0 #906

Closed
wants to merge 7 commits into from

Conversation

yisraelU
Copy link
Collaborator

@yisraelU yisraelU commented Aug 15, 2024

Redis 7.4.0 introduces a few important commands that provide the ability to set expirations on fields of a hash instead of the key.
They are :
Hexpire,HexpireAt,HexpireTime,Hpersist,HTTL
and with ms precision
HPexpire,HPexpireAt,HpexpireTime,HPTTL

@yisraelU yisraelU changed the title init Hash Expiration commands Aug 15, 2024
@yisraelU yisraelU changed the title Hash Expiration commands Hash Expiration commands for redis 7.4.0 Aug 15, 2024
@yisraelU yisraelU marked this pull request as ready for review August 19, 2024 17:10
@yisraelU
Copy link
Collaborator Author

yisraelU commented Aug 19, 2024

The CI is currently failing for the redis cluster spec , because we dont have a Redis Cluster docker image for 7.4. Should we proceed rergardless, as I fear it might be some time until @Grokzen releases a new image ?
@gvolpe

@gvolpe
Copy link
Member

gvolpe commented Aug 20, 2024

I don't think we should support Redis 7.4 at all due to the license change. I would be more inclined to continue this project along the lines of ValKey instead, even if it takes longer to get there. See Grokzen/docker-redis-cluster#166 (comment)

Part of a bigger discussion that should happen on #863, but for now let's refrain from making breaking changes - i.e. changes that are not compatible with the latest open source Redis or Valkey.

@yisraelU
Copy link
Collaborator Author

@gvolpe
Okay, that makes sense. I admit I did not read too much about the licensing and how it affects the open source community.
Valkey supports redis 7.2, so we can still add a few more commands.

Is the idea going forward, to change the underlying library to something that supports Valkey?

@gvolpe
Copy link
Member

gvolpe commented Aug 21, 2024

I'm not sure yet, that requires a bigger discussion that I'm not ready to have yet, but it should be discussed in #863 .

For now let's stick to maintaining compatibility with open source Redis, v7.2.5 is the latest version we can support.

@yisraelU
Copy link
Collaborator Author

Closing pr per conversation

@yisraelU yisraelU closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants